This functions should accept the type of integer they say to write. Calling
the u32 function with an integer that is actually 32 bit unsigned gives
compiler warnings.
---
src/openvpn/buffer.h | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h
index 97cc86241..231f1b0d4 100644
--- a/src/openvpn/buffer.h
+++ b/src/openvpn/buffer.h
@@ -694,23 +694,22 @@ buf_write_prepend(struct buffer *dest, const void *src,
int size)
}
static inline bool
-buf_write_u8(struct buffer *dest, int data)
+buf_write_u8(struct buffer *dest, uint8_t data)
{
- uint8_t u8 = (uint8_t) data;
- return buf_write(dest, &u8, sizeof(uint8_t));
+ return buf_write(dest, &data, sizeof(uint8_t));
}
static inline bool
-buf_write_u16(struct buffer *dest, int data)
+buf_write_u16(struct buffer *dest, uint16_t data)
{
- uint16_t u16 = htons((uint16_t) data);
+ uint16_t u16 = htons(data);
return buf_write(dest, &u16, sizeof(uint16_t));
}
static inline bool
-buf_write_u32(struct buffer *dest, int data)
+buf_write_u32(struct buffer *dest, uint32_t data)
{
- uint32_t u32 = htonl((uint32_t) data);
+ uint32_t u32 = htonl(data);
return buf_write(dest, &u32, sizeof(uint32_t));
}
--
2.32.0 (Apple Git-132)
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
