Hi, On Thu, May 12, 2022 at 02:14:29PM +0200, Arne Schwabe wrote: > The test_check_ncp_ciphers_list test assumed that BF-CBC is always > available, which is no longer the case with OpenSSL 3.0. Rewrite the > test to not rely on BF-CBC to be available.
This should be a cherry-pick from c07f95f3cacd, but "something went
wrong"
> static void
> @@ -57,6 +58,11 @@ test_check_ncp_ciphers_list(void **state)
>
> assert_string_equal(mutate_ncp_cipher_list(aes_ciphers, &gc),
> aes_ciphers);
>
> + if (have_chacha && have_blowfish)
> + {
> + assert_string_equal(mutate_ncp_cipher_list(aes_chacha, &gc),
> aes_chacha);
> + }
In c07f95f3cacd, the first if() is only "if (have_chacha)", and that
seems to make more sense since that test does not depend on BF...
> +
> if (have_chacha && have_blowfish)
> {
... only this one does...
can I have a 7/7 v2, please? :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
