Acked-by: Gert Doering <g...@greenie.muc.de>

Trivial enough, and confirmed that it does not break anything.

(Having the "has_digit()" in buffer.*h* when it is only ever called
from tun.c smells like "we might eventually include this in 
tun_name_is_fixed() and get rid of the inline helper" - but this is
a patch for another day.  Also, we might do it the other way round,
"everything that is not exactly 'tun', 'tap' or 'null' is considered 
fixed" - this whole open_tun() thing is a hairy mess of historic insanity).

Your patch has been applied to the master branch.

commit 4a88d2fbe73a64f8f3861089a2b6e3b8e583e71b
Author: Antonio Quartulli
Date:   Wed Jul 13 00:16:55 2022 +0200

     tun: create tun_name_is_fixed helper

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220712221655.19333-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24676.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to