Taking the agreement from Arne as formal ACK (checked on IRC).
I'm not sure I grok all the details of this, but I can attest that
unit_tests/test_provider still works (on a 3.0.x build), and that calls
the "xkey_load_generic_key()" function being modified here. So, this
is good. Lev promised to verify MSVC builds early next week.
Your patch has been applied to the master branch.
commit 2b2e4d0ad5c3a309af8425be8e6e605975fb2a43
Author: Selva Nair
Date: Wed Jul 6 23:51:51 2022 -0400
Fix crash in xkey-provider in msvc builds
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Arne Schwabe <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg24664.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
