Thanks for v2, and "too many #ifdef" indeed.  Uncrustify complained that
one of the #endif wants a comment, but with the new commit hooks this 
is easily fixed.  (Maybe we want to have a deep look into "do we really
want to keep ENABLE_MANAGEMENT?" one day... how much extra code size
does that bring to the binaries?  It's not *that* much code, is it?)

I have fed the code to buildbot, and it pacified all these modern
instances (fedora-36 etc.) ;-)

Your patch has been applied to the master branch.

commit fc75ab33401718fab3a79b19698eefb70a617a83
Author: Selva Nair
Date:   Wed Jul 27 18:18:30 2022 -0400

     xkey_provider: fix building with --disable-management

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
     Message-Id: <20220727221830.31861-1-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24749.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to