The authfail_extended and buf variables are only used when
ENABLE_MANAGEMENT is defined. However, they are currently declared
outside of any ifdefs, thus triggering a warning.
Move the declaration of these 2 down, right before their usage (within
the existing "#ifdef ENABLE_MANAGEMENT" block.
Fixes: ("Cleanup receive_auth_failed and simplify method")
Cc: Arne Schwabe <a...@rfc2549.org>
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
---
src/openvpn/push.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/openvpn/push.c b/src/openvpn/push.c
index d0038795..51dc8359 100644
--- a/src/openvpn/push.c
+++ b/src/openvpn/push.c
@@ -58,12 +58,6 @@ receive_auth_failed(struct context *c, const struct buffer
*buffer)
return;
}
- struct buffer buf = *buffer;
-
- /* If the AUTH_FAIL message ends with a , it is an extended message that
- * contains further flags */
- bool authfail_extended = buf_string_compare_advance(&buf, "AUTH_FAILED,");
-
/* Before checking how to react on AUTH_FAILED, first check if the
* failed auth might be the result of an expired auth-token.
* Note that a server restart will trigger a generic AUTH_FAILED
@@ -95,6 +89,11 @@ receive_auth_failed(struct context *c, const struct buffer
*buffer)
c->sig->signal_text = "auth-failure";
}
#ifdef ENABLE_MANAGEMENT
+ struct buffer buf = *buffer;
+ /* If the AUTH_FAIL message ends with a , it is an extended message that
+ * contains further flags */
+ bool authfail_extended = buf_string_compare_advance(&buf, "AUTH_FAILED,");
+
if (management)
{
const char *reason = NULL;
--
2.35.1
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
