Hi, On Thu, Aug 04, 2022 at 05:03:00PM +0200, Frank Lichtenheld wrote: > We only need to include this when we want the > git version. This is currently only the case > in options.c
Feature-ACK, but NAK on this hunk:
> diff --git a/src/openvpn/plugin.c b/src/openvpn/plugin.c
> index 51136fea..dc7fd459 100644
> --- a/src/openvpn/plugin.c
> +++ b/src/openvpn/plugin.c
> @@ -26,9 +26,6 @@
> #elif defined(_MSC_VER)
> #include "config-msvc.h"
> #endif
> -#ifdef HAVE_CONFIG_VERSION_H
> -#include "config-version.h"
> -#endif
plugin.c actually uses CONFIGURE_GIT_REVISION for the openvpn version
visible to plugins
#ifndef CONFIGURE_GIT_REVISION
#define _OPENVPN_PATCH_LEVEL OPENVPN_VERSION_PATCH
#else
#define _OPENVPN_PATCH_LEVEL "git:" CONFIGURE_GIT_REVISION CONFIGURE_GIT_FLAGS
#endif
...
struct openvpn_plugin_args_open_in args = { p->plugin_type_mask,
...
_OPENVPN_PATCH_LEVEL};
The other two (block_dns.c and tapctl.c) can go.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
