Hi,
> On Windows the high level API should still use the link_socket object to
> read and write packets. For this reason, even if dco_installed is true,
> we still need to rely on the classic link_socket object.
This is true.
>
> + *
> + * Windows DCO needs control packets to be sent via the normal
> + * Socket API.
This is a bit confusing IMHO. What does "Socket API" mean here?
To read/write control packets we use what Windows calls "Overlapped I/O",
basically asynchronous IO with Write/ReadFile and events. We do not use
Winsock API, even though the OpenVPN function we use is called
"link_socket_write_win32()".
I would change the above mentioned comment to "normal Overlapped I/O".
Maybe this could be done at commit.
Also, as mentioned in chat, this should be merged before 3/7
("dco-win: implement ovpn-dco support in P2P Windows code path").
Acked-by: Lev Stipakov <[email protected]>
-Lev
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
