Thanks.  This was left hanging in the cold for some reason... merged
now.  I've subjected it to the usual test for DCO related stuff (client
with no-dco kernel, client with dco, server with dco) and verified that
the same instances have DCO enabled that had before - glad for Arne's
GLOBAL_STATS patch now :-)

This *should* be safe even on windows, as windows patch 1/7 changes
the first condition to "if (!dco_enabled(o) ...)" so it won't abort on
DCO-incompatible option in a config that does not have "windows-driver dco"
in the first place.

I have rewrapped the comment to better fit into 80 char line constraints
(since the second line was quite short)

Your patch has been applied to the master branch.

commit 78b8d0e162e1fa34780ee3d3ea84691539a0b1f3
Author: Antonio Quartulli
Date:   Tue Aug 2 15:03:12 2022 +0200

     dco: move availability check to the end of check_option_conflict() function

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
     Message-Id: <20220802130312.18871-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24783.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to