I’ll post a patch.
> - any particular reason you used argv_printf() + argv_printf_cat(),
> instead of just putting all into a single argv_printf() call?
>
Mostly that that’s what src/openvpn/networking_iproute2.c does too. I
don’t have particularly strong feelings either way, so I’ll add that to
the upcoming patch.
> - the "openvpn_execve_check()" messages state "route *add* command failed",
> while it could be "del" as well. Making this "proper" might not be
> worth it, as it would need string manipulation (or "duplicate whole
> message").
>
It might be nice to turn openvpn_execve_check() into a variadic function
so we could do this:
status = openvpn_execve_check(&argv, NULL, 0,
"ERROR: FreeBSD route %s command failed”, op);
But I think I’ll just remove the ‘add’, which makes the error message
make sense for both add and del.
Best regards,
Kristof
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
