On Fri, Aug 26, 2022 at 10:54:27AM +0200, Frank Lichtenheld wrote:
> Signed-off-by: Frank Lichtenheld <[email protected]>
Looking a bit closer at the changes this one seems slightly broken.
Examples:
> diff --git a/src/openvpn/misc.h b/src/openvpn/misc.h
> index 2a6c0b8b..7ad19bf7 100644
> --- a/src/openvpn/misc.h
> +++ b/src/openvpn/misc.h
[...]
> @@ -217,7 +217,7 @@ prepend_dir(const char *dir, const char *path, struct
> gc_arena *gc);
> /* *INDENT-ON* */
> #define MAC_PRINT_ARG(_mac) _mac[0], _mac[1], _mac[2], \
> _mac[3], _mac[4], _mac[5]
> -#define MAC_SCAN_ARG(_mac) &_mac[0], &_mac[1], &_mac[2], \
> +#define MAC_SCAN_ARG(_mac) & _mac[0], &_mac[1], &_mac[2], \
> &_mac[3], &_mac[4], &_mac[5]
>
> #endif /* ifndef MISC_H */
[...]
> diff --git a/src/openvpn/openssl_compat.h b/src/openvpn/openssl_compat.h
> index 9d89bd0a..26e99f24 100644
> --- a/src/openvpn/openssl_compat.h
> +++ b/src/openvpn/openssl_compat.h
> @@ -211,7 +211,7 @@ X509_get0_pubkey(const X509 *x)
> * @return the X509 object stack
> */
> static inline STACK_OF(X509_OBJECT)
> -*X509_STORE_get0_objects(X509_STORE *store)
> +* X509_STORE_get0_objects(X509_STORE * store)
> {
> return store ? store->objs : NULL;
> }
So this seems to misinterpret '*' and '&' after ')'.
This doesn't break compilation but is really ugly and confusing.
So NAKing my own patch ;)
Regards,
Frank
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
