I have tested this on the server test bed, to ensure it does not
"drive by" break anything else (doesn't look like it, but testing is
better). Doesn't :-) - I have not actually tested the CRRESPONSE script
functionality.
I have slightly changed the commit message, to fix grammar/typo.
Looking at the discussions around the error message and the resulting
code (why not exit early on "if (!tmp_file)"?) I wonder why we do not
have a more generic "create a tmp_file, fill it with $string, do
proper error messages, return true/false" function for this... and
what this "status_open()" stuff is about, for wrting a plain text file.
But this is for a separate cleanup/refactoring patch.
On the patch itself, since this does not introduce new asynchronous
authentication, just extra hooks that are done (or not) and can succeed
synchronously (or not), the changes should be fine. Heiko and David
already reviewed this.
Next: 11/11 v4 + ACK, please :-)
Your patch has been applied to the master branch.
commit 23eec2d29435a51771dcd4f85d71f33465a174ff
Author: Arne Schwabe
Date: Wed Aug 24 13:09:30 2022 +0200
Implement --client-crresponse script options and plugin interface
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Heiko Hund <he...@ist.eigentlich.net>
Message-Id: <20220824110930.73009-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25089.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
