This patch need to be rebased again, does not apply to master anymore: checking file src/openvpn/ssl.c Hunk #1 succeeded at 297 (offset 1 line). Hunk #2 FAILED at 321. Hunk #3 succeeded at 1256 (offset -42 lines).
On Mittwoch, 11. Mai 2022 13:08:10 CEST Arne Schwabe wrote: > @@ -141,6 +147,8 @@ User-visible Changes > +- control channel packet maximum size is no longer influenced by ``--link- mtu``/``--tun-mtu`` > + and must be set by ``--tls-mtu`` now. Must it or is there still some cc-mtu derivation in place in case it is not given? If not, wouldn't it make sense to at least catch obvious breakage. Usually link/tun-mtu is lowered for that reason. Further down in the patch there are min/max_int() calls in tls_init_control_channel_frame_parameters(), do they do what I suggested here already? > diff --git a/doc/man-sections/link-options.rst > +--tls-mtu size Is --tls-mtu the best name for the option we can come up with? From my outside perspective (can hardly spell mtu right) the "tls" part is somewhat misnamed, as this is an SSL VPN after all. When you know that the framing for the data channel is not TLS you can make sense of it, but who does. > + The maximum packet size includes encapsulation overhead like UDP > and IP. > \ No newline at end of file ^ this > + int tls_mtu; /* Maximum MTU for the > control channel messages */ The "M" already stands for "Maximum". _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
