"Anything that touches DCO" is suspect :-) - so I've submitted this
to Linux and FreeBSD DCO server tests, and everything passed (or,
precisely, only well-known problems failed). Instances still use
DCO where they should.
The whole "msglevel" thing passed to functions like dco_available() might
need a bit of extra review when the dust has settled - is this still useful,
or do we (now) always pass the same thing anyway (since windows and M_USAGE
is gone now)? dco_check_option() is called with D_DCO and D_MULTI_ERRORS,
but the call tree with dco_check_startup_option() is only called once...
The whole "--windows-driver" thing is also something we might want to
revisit. It's quite a bit of code spilling to places that do not really
want to know (like, options.c)...
Nevertheless, this patch is doing quite a bit of good for removing #ifdef
relating to "DCO platforms", which is good :-)
Your patch has been applied to the master branch.
commit e9a156a160bb71e03ae03ba0bf4f31ced7282a13
Author: Lev Stipakov
Date: Thu Sep 15 13:40:28 2022 +0300
Use DCO on Windows by default
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Message-Id: <20220915104028.188-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25221.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
