On Tue, Aug 30, 2022 at 01:49:58PM +0300, Lev Stipakov wrote: > From: Lev Stipakov <l...@openvpn.net> > > Since version 0.8.0, dco-win driver added support for > DEL_PEER command, which enabled --persist-tun > implementation on client side. > > Add real implementation for dco_del_peer on Windows, > which calls DEL_PEER, which clears peer state > on the driver without tearing tunnel down. > > When pulled options are changed on restart, > we need to close and reopen tun device. This > is not yes supported for dco-win, so we close > tun and trigger reconnect.
Code looks good to me. And I have lightly tested it against my AS with a MSI provided by Lev. One thing of note is that I first tried to test it with a new openvpn binary against a slightly older driver and that sent openvpn into a restart loop where the NEW_PEER call failed but then it just tried it again. Would it be a good idea (and possible) to improve the error handling in a way that if the soft-restart fails it instead tries a hard-restart? Anyway, since I do not think this specific problem is caused by this patch: Acked-By: Frank Lichtenheld <fr...@lichtenheld.com> Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
