Hi,
On 04/10/2022 16:51, Gert Doering wrote:
FreeBSD 14 clang complains about this:
and it is right.
init.c:3530:13: warning: use of bitwise '|' with boolean operands
[-Wbitwise-instead-of-logical]
platform_group_get(c->options.groupname, &c0->platform_state_group)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
init.c:3530:13: note: cast one or both operands to int to silence this warning
1 warning generated.
.. so do what it wants us to do.
Signed-off-by: Gert Doering <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
---
src/openvpn/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 03416844..c88c0915 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -3528,7 +3528,7 @@ do_init_first_time(struct context *c)
/* get user and/or group that we want to setuid/setgid to */
c0->uid_gid_specified =
platform_group_get(c->options.groupname,
&c0->platform_state_group)
- |platform_user_get(c->options.username, &c0->platform_state_user);
+ || platform_user_get(c->options.username,
&c0->platform_state_user);
/* perform postponed chdir if --daemon */
if (c->did_we_daemonize && c->options.cd_dir == NULL)
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
