On Mon, Oct 10, 2022 at 10:00:37AM +0200, Antonio Quartulli wrote:
> > -        if (username)
> > +        if (username && *username)
> super uber nitpick (bike shadding level):
> I think in other places we perform the very same check using the format: 
> username[0] instead of *username.

I can adjust that in a v2, but first I need to hear what Arne thinks
about this - it's all his code, so I want to be sure that this is not
introducing unexpected side effects.

"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

Openvpn-devel mailing list

Reply via email to