Acked-by: Gert Doering <g...@greenie.muc.de>
Testing this was fairly easy - I added a msg() call in that if()
branch, connected to a server with auth-token and verified that it did
the strncpynt() only on the "I have a real username here" call. And
that token reauth still works ("username properly copied"), which
it all did.
Your patch has been applied to the master branch, for now - it needs
to go to 2.5 as well, but we're right in the middle of a 2.5.8
release, and I need to check with Samuli & Frank if anything has been
done already that would cause havoc if I change the (preliminary)
v2.5.8 tag...
commit dbf142ffe597b21aa09a47677ea2061b74a9354e
Author: Selva Nair
Date: Thu Oct 27 12:06:19 2022 -0400
Do not copy auth_token username to itself
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20221027160619.11894-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/search?l=mid&q=20221027160619.11894-1-selva.n...@gmail.com
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
