Acked-by: Gert Doering <g...@greenie.muc.de>
My first thought was "trivial enough", the second thought was "oh wait"
- the old code copies "src->addr" to "dst->addr", while the new code copies
"src" to "dst". Now, src/dst are "struct openvpn_sockaddr" here, which
is a struct containing only one member, "->addr" (which is a union) - so
the copying does the same thing, just with shorter source code lines.
Of course I have actually tested this :-) - the windows function has
only been compile tested (github actions, no errors) and the unix
function has been client-side tested with tests including TCP.
Your patch has been applied to the master branch.
commit 470d1d149aac162fac3390e7dcb29c2a9ea7dba4
Author: Arne Schwabe
Date: Wed Nov 9 12:07:49 2022 +0100
Remove unused addr_inet4or6, addr_guess_family and inline addr_copy_sa
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20221109110749.1245175-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25493.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
