Hi,

On Fri, Nov 25, 2022 at 12:00:25AM +0100, Arne Schwabe wrote:
> The lifetime and state machine of multi->peer_id does not exactly the
> lifetime/state of DCO. This is especially for p2p NCP where a reconnection
> can change the peer id. Also use this new field with value -1 to mean
> not installed, replacing the dco_peer_added field.
> 
> Patch v2: fix one comparison checking for 0 instead of -1

This looks good, but fails the server test - after the first few
client connects it seems to get confused on peer installation, and dies
miserably

Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: MULTI: primary virtual IPv6 
for freebsd-14-amd64/194.97.140.5:13776: fd00:abcd:220:2::1002
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_new_peer: netlink reports 
error (-6): Object exists: No such file or directory (errno=2)
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_new_peer: failed to send 
netlink message: File exists (-17)
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Cannot add peer to DCO: File 
exists (-17)
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_set_peer: netlink reports 
object not found, ovpn-dco unloaded?
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_set_peer: failed to send 
netlink message: No such file or directory (-2)
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Cannot set parameters for DCO 
peer (id=4294967295): No such file or directory

   >>> now that id= hints at "something has not been initialized properly"
   >>> as that is "(unsiged int) -1"

Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Data Channel: using negotiated 
cipher 'AES-256-GCM'
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Data Channel MTU parms [ 
mss_fix:1380 max_frag:0 tun_mtu:1500 tun_max_mtu:1600 headroom:136 payload:1768 
tailroom:562 ET:0 ]
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_new_key: netlink reports 
object not found, ovpn-dco unloaded?
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: dco_new_key: failed to send 
netlink message: No such file or directory (-2)
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Impossible to install key 
material in DCO: No such file or directory
Nov 25 09:51:53 ubuntu2004 tun-udp-p2mp[641000]: Exiting due to fatal error


(This is plain p2mp udp TLS server, with t_client client connecting to
it - same client cert, but new connection, new source ip/port - there
is a second client connected for client-to-client testing)

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to