Hi,

On Tue, Nov 29, 2022 at 01:37:56PM -0500, selva.n...@gmail.com wrote:
> +    /* skip leading spaces matching the behaviour of parse_line */
> +    while(*line && space(*line))

I would actually prefer to use isspace(*line) here.  space() is one
of our special magic functions which returns true on 0-byte *or* isspace(),
which won't have an effect (as *line checks for the 0 already), but will
just confuse readers wrt "how is space() different from isspace()?".

Can you send a v3?  ACK on that :-)

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to