Hi, On Tue, Dec 06, 2022 at 04:54:38PM +0100, Gert Doering wrote: > I have not server-tested this, as it "should not" make a difference, > and Arne did test this on s390. The full server tests will run > tonight, though.
I *should* have, as that would have caught the fact that this patch
breaks pkt_testdriver on Linux, no matter if OpenSSL or mbedTLS
[ RUN ] test_calc_session_id_hmac_static
[ ERROR ] --- difference at offset 0 0xffffff84 0xffffff8b
difference at offset 1 0x73 0xffffffeb
difference at offset 2 0x52 0x3d
difference at offset 3 0x2b 0x20
difference at offset 4 0x5b 0x14
difference at offset 5 0xffffffa9 0x53
difference at offset 6 0x2a 0xffffffbe
difference at offset 7 0x70 0x0a
8 bytes of 0x7ffe60967bd0 and 0x7ffe60967bc8 differ
[ LINE ] --- test_pkt.c:492: error: Failure!
[ FAILED ] test_calc_session_id_hmac_static
...
[==========] 9 test(s) run.
[ PASSED ] 8 test(s).
[ FAILED ] 1 test(s), listed below:
[ FAILED ] test_calc_session_id_hmac_static
1 FAILED TEST(S)
FAIL: pkt_testdriver
this is not specific to OpenSSL (1.1.1*) or mbedTLS, but seems to
be "a Linux thing", so I assume it's something related to sockaddr
(as this patch fixes the switch/case to actually look at the IPv4 addr)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
