Hi,

This is good - I need an API to get stats to make openvpn-gui show
those (via the management interface).

I am not too much into FreeBSD parts, but

> +    hash_iterator_init(m->hash, &hi);
> +
> +    while ((he = hash_iterator_next(&hi)))
> +    {
> +        struct multi_instance *mi = (struct multi_instance *) he->value;
> +
> +        if (mi->context.c2.tls_multi->peer_id != peerid)
> +            continue;

Shouldn't we use m->instances[peerid] instead of iterating over m->hash?

from multi.h:

struct multi_context {
    struct multi_instance **instances;  /**< Array of multi_instances.
An instance can be
                                         * accessed using peer-id as
an index. */
-- 
-Lev


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to