Am 12.12.22 um 12:56 schrieb Lev Stipakov:
From: Lev Stipakov <l...@openvpn.net>
At the moment BYTECOUNT in,out is pushed if there is traffic.
With DCO, userspace process doesn't see the traffic, so we need
to add a timer which periodically fetches stats from DCO and
pushes to management client. The timer interval is set by existing
"bytecount n" management command.
This commit only adds a timer, stats fetching from DCO will be added
later.
If you do the timers anyway why keep the other logic that triggers on
updating the byte count? That feels duplicating and
unnecessary complexity. So if we switch to a timer, I would strongly
advocate to remove the other code path to avoid having two code paths
that only add complexity but do not offer any significant (none?)
benefit vs only keeping the timer.
Arne
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
