Acked-by: Gert Doering <[email protected]>
stare-at-code confirms that this is a simple-enough fix.
One could argue for moving the fclose(fp) up before the tangled if/else/...
construct, but this one will do and is easy enough to review "it will
not change anything except in case of error".
Your patch has been applied to the master, release/2.6 and release/2.5 branch.
commit a034dc8153522713c3cfda90b2cda114cea70e2d (master)
commit 03f990b4df00bfb2cb9aa93155420efa935011b5 (release/2.6)
commit 1ec71f4568e13f2876e6ec15f1efda530693d2e9 (release/2.5)
Author: Arne Schwabe
Date: Thu Dec 15 20:01:42 2022 +0100
Fix corner case that might lead to leaked file descriptor
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg25730.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel