On Mon, Dec 19, 2022 at 01:21:37PM +0100, Frank Lichtenheld wrote:
> > +        /* peer-id and auth-token might change on restart and this should 
> > not trigger reopening tun */
> > +        if (strprefix(line, "peer-id ") || strprefix(line, "auth-token"))
> If I interpret this correctly, this will also exclude auth-token-user, 
> because you didn't
> add the space after the option name like for peer-id. This should either be 
> reflected
> in the comment above or changed.

Well spotted.  For "less magic, easier understanding" reasons I'd actually
include it explicitly

 +        if (strprefix(line, "peer-id ")
              || strprefix(line, "auth-token ")
              || strprefix(line, "auth-token-user "))

(with blank) - yes, Selva's original code does that, but more magically.


"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

Openvpn-devel mailing list

Reply via email to