The patch needed a bit of convincing to go in (context change in options.h,
and braces-in-the-wrong-line).  Fixed.

Tested with a config with 200 somewhat random remote lines - without the
patch

  Options error: Maximum number of 'remote' options (64) exceeded

and with the patch "it just works"...

    remote-entry-count
    206
    END
    remote-entry-get 200 999
    200,1195.server.org,1195,udp
    201,1196.server.org,1196,udp
    202,1197.server.org,1197,udp
    203,1198.server.org,1198,udp
    204,1199.server.org,1199,udp
    205,1200.server.org,1200,udp
    END

(I did not try 100s of <connection>)


That said, I'm not convinced we really need to print

  2022-12-27 10:16:56 WARNING: Using --management on a TCP port WITHOUT 
passwords is STRONGLY discouraged and considered insecure

for every single --remote...  but that's a different issue, not caused
by *this* patch.

Your patch has been applied to the master branch.

commit 4954beb618e8bf2dc756019d5a36040d791a8f38 (master)
commit ceba452ee44439b426b786325db2b4e1b1c8b663 (release/2.6)
Author: Selva Nair
Date:   Tue Sep 7 18:31:25 2021 -0400

     Permit unlimited connection entries and remotes

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <20210907223126.8440-2-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22816.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to