Acked-by: Gert Doering <[email protected]>
The initial tests were left to Github/ASAN builds, which are now
"all green for real" -
https://github.com/cron2/openvpn/actions/runs/3789030448
Stare-at-code also looks good, though a bit complicated (and if I'm
reading this right, doing an initial allocation with gc_malloc() and
then calling gc_realloc() on it will double-free(), so *boom*) - sufficient
for the use case at hand (initial allocation also done with gc_realloc()),
but maybe it could be simplified and made robust against this case.
My manual "test one instance with 200 remotes" did what I expected
(and I discovered --management-query-remote ;-) ).
Your patch has been applied to the master and release/2.6 branch.
commit e7f2169772f90f9bf158a17f5656a6a985e74e31 (master)
commit 09267c1ccde6a8f0671c785413ca847e97bbc0a5 (release/2.6)
Author: Arne Schwabe
Date: Tue Dec 27 15:02:45 2022 +0100
Replace realloc with new gc_realloc function
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg25829.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
