Acked-by: Gert Doering <[email protected]>
This is basically the same thing as 1/5, just for the getaddrinfo()
related functions. And no, I have no idea why they are treated "special",
and getaddrinfo() is not a syscall. OTOH, getaddrinfo() spends most of
its time in "waiting for DNS packets", which might result in visible
behaviour similar to a restarted/restartable syscall on signals coming
in... the "let's rewrite that thing" part would be 2.7 material, though.
The code changes look reasonable ("straightforward as 1/5"), the test
rigs still works I do not have specific "test signal handling / timeout
in DNS" test cases today, though.
Your patch has been applied to the master and release/2.6 branch.
commit eff95d500481c7927c5a9edd6b5c0dfa056a0cbb (master)
commit 1ff87267f819b512c34a202b9a023c76e7031af4 (release/2.6)
Author: Selva Nair
Date: Sun Jan 1 16:51:06 2023 -0500
Refactor signal handling in openvpn_getaddrinfo
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg25872.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
