On Fri, Jan 6, 2023 at 9:16 AM Lev Stipakov <lstipa...@gmail.com> wrote:
> Hi,
>
> > else if ((flags & ROUTE_METHOD_MASK) == ROUTE_METHOD_IPAPI)
> > {
> > status = add_route_ipapi(r, tt, ai);
> > - msg(D_ROUTE, "Route addition via IPAPI %s", status ?
> "succeeded" : "failed");
> > + msg(D_ROUTE, "Route addition via IPAPI %s", (status == 1) ?
> "succeeded/skipped" : "failed");
> > }
>
> Under what conditions we might get "skipped"?
>
My mistake -- I had initially left it at "status ?" which would now include
already exists, but then the logs looked odd as it first prints "failed"
with M_WARN in add_route_ipapi, and then "succeeded/skipped" here. On
changing to "status==1", I missed to remove "skipped".
I'm assuming we want to continue printing a warning when route addition
fails due to "already exists" though we wont pass that as an error to
initialization_completed (next commit).
Time for v2.
Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
