I've stared at the code for a bit ("git show -w" helps), but not having
deep understanding of all windows/management intricacies, I can only say
"it looks reasonable".

I have also built a test binary (Ubuntu/MinGW) which behaved properly when
called from the CLI.  Tested F1, F2, F3, F4 and ctrl-C.

I have also recreated the test Lev has done, connect to a non-working
server with "--connect-retry 30" and try to press ctrl-c when sleeping -
did not work before, works now.

Your patch has been applied to the master and release/2.6 branch.

commit 22977577ed128ac953e7ebfe30f839bcf651b334 (master)
commit dec9c03d0f6e184fb6cce16b554491d62622425c (release/2.6)
Author: Selva Nair
Date:   Thu Jan 5 19:54:38 2023 -0500

     Fix signal handling on Windows

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Lev Stipakov <lstipa...@gmail.com>
     Message-Id: <20230106005438.1664046-1-selva.n...@gmail.com>
     Signed-off-by: Gert Doering <g...@greenie.muc.de>

kind regards,

Gert Doering

Openvpn-devel mailing list

Reply via email to