Acked-by: Gert Doering <g...@greenie.muc.de>
This is really straightforward. Tested with my .ovpn full with generated
"remote" lines, some of them changed to "tcp", and "--proto-force tcp-client"
..
190,1185.server.org,1185,udp,disabled
191,1186.server.org,1186,udp,disabled
192,1187.server.org,1187,udp,disabled
193,1188.server.org,1188,tcp-client,enabled
194,1189.server.org,1189,tcp-client,enabled
195,1190.server.org,1190,tcp-client,enabled
(NOTE: "--proto-force tcp" will surprisingly - to me - disable *everything*,
because "client side TCP profiles are 'tcp-client', not 'tcp'")
This said, the code with all these strlen() and malloc() calls for every
single remote looks fumbly... given that it's not exactly geared for
maxmimum memory efficientcy, I'm tempted to suggest just having an
on-the-stack "char remote[1000];" in man_remote_entry_get(), and pass
a pointer to that + sizeof() to "...callback.remote_entry_count()".
But this is something for the next round of cleanup in early 2.7.
I have reordered the example lines in the commit message.
Your patch has been applied to the master and release/2.6 branch.
commit eafbedc583c48fd46405fa0d635c688ce59c3733 (master)
commit 69383817b9805137460c0e25ede4b18573cac01d (release/2.6)
Author: Selva Nair
Date: Wed Jan 11 01:29:10 2023 -0500
Include CE_DISABLED status of remote in remote-entry-get response
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20230111062910.1846688-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/search?l=mid&q=20230111062910.1846688-1-selva.n...@gmail.com
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
