Hi,
On Tue, Jan 10, 2023 at 06:02:57PM +0100, Frank Lichtenheld wrote:
> @@ -27,7 +27,7 @@ ${top_builddir}/src/openvpn/openvpn --cd
> ${top_srcdir}/sample --config sample-co
> # first off check we died because of a key mismatch. If this doesn't
> # pass, suspect openssl of returning different messages and update the
> # test accordingly
> -loggrep '(X509_check_private_key:key values
> mismatch|func\(128\):reason\(116\))' log.txt || { echo "Key mismatch not
> detected"; exit 1; }
> +loggrep '(x509 certificate routines:(X509_check_private_key)?:key values
> mismatch|func\(128\):reason\(116\))' log.txt || { echo "Key mismatch not
> detected"; exit 1; }
This change does not convince me - assuming normal regex here, the
original grep would have found any lines with
X509_check_private_key:key values mismatch
in them, while the new one would find
X509_check_private_key::key values mismatch
X509_check_private_key:X509_check_private_key:key values mismatch
but not "the old one with just one :"
Should this be
(x509 certificate routines:(X509_check_private_key:)?key va...
with the second ":" part of the (...:)? zero-or-once match?
(... as a side note, I hate this test... it's easily the test with the
most commits to make it behave across platforms and SSL library versions)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
