Hi,

On Thu, Jan 12, 2023 at 12:50:52AM +0100, Antonio Quartulli wrote:
> diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
> index 77dcaa60..99123c39 100644
> --- a/src/openvpn/multi.c
> +++ b/src/openvpn/multi.c
> @@ -3244,6 +3244,10 @@ process_incoming_del_peer(struct multi_context *m, 
> struct multi_instance *mi,
>              reason = "ovpn-dco: transport error";
>              break;
>  
> +        case OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT:
> +            reason = "ovpn-dco: transport disconnected";
> +            break;
> +

We were too fast in ACKing and merging this "because rc2" - this breaks
compilation on FreeBSD+DCO, because it only adds the necessary enum
element for Linux.

This being an enum, I can't even add an "#ifdef ...TRANSPORT_DISCONNECT"
here, and because these codes need to be synchronized between kernel and
userland, I can't "just add it to freebsd_dco.h".

So consider me not very amused...

As a quick bandaid, I'll send a patch that adds an #ifdef TARGET_LINUX
around this clause so I can update the FreeBSD openvpn-devel port - but
that is not a really good solution either.  @kp, what would you suggest
how to handle this on the FreeBSD side?

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to