I reproduced the bug by disabling IPv6 on the DCO adapter and verified that this patch fixes the problem. Code looks obvious enough.
Could there be clients with IPv6 enabled and IPv4 disabled? :) Acked-by: Lev Stipakov <[email protected]> ke 22. maalisk. 2023 klo 17.16 [email protected] kirjoitti: > > From: Selva Nair <[email protected]> > > - Unfortunately there are still users out there who disable IPv6 > on tun/tap/dco interfaces or even system-wide. > > Fixes: Github issue #294 > Signed-off-by: Selva Nair <[email protected]> > --- > src/openvpnserv/interactive.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c > index a3d43752..98a42b1f 100644 > --- a/src/openvpnserv/interactive.c > +++ b/src/openvpnserv/interactive.c > @@ -847,8 +847,8 @@ AddBlockDNS(const block_dns_message_t *msg, undo_lists_t > *lists) > BLOCK_DNS_IFACE_METRIC); > if (!err) > { > - err = set_interface_metric(msg->iface.index, AF_INET6, > - BLOCK_DNS_IFACE_METRIC); > + set_interface_metric(msg->iface.index, AF_INET6, > + BLOCK_DNS_IFACE_METRIC); > } > if (err) > { > -- > 2.34.1 > > > > _______________________________________________ > Openvpn-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openvpn-devel -- -Lev _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
