Hi,

On Thu, Mar 23, 2023 at 06:06:01PM +0100, Arne Schwabe wrote:
> This change keeps the option parsing of compression options even when
> compression is disabled. This allows OpenVPN to also refuse/reject connections
> that try to use compression when compression is completely disabled.

Amazing as that might be, if you actually disable compression, master + 4/4
does not compile anymore...

depbase=`echo init.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H 
-I. -I../.. -I../../include  -I../../include  -I../../src/compat            
-DPLUGIN_LIBDIR=\"/usr/local/lib/openvpn/plugins\"  -Wall -g -O2 -std=c99 -MT 
init.o -MD -MP -MF $depbase.Tpo -c -o init.o init.c && mv -f $depbase.Tpo 
$depbase.Po
init.c:2648:9: warning: implicit declaration of function 'comp_uninit' is
      invalid in C99 [-Wimplicit-function-declaration]
        comp_uninit(c->c2.comp_context);
        ^
init.c:2648:27: error: no member named 'comp_context' in 'struct context_2'; did
      you mean 'mda_context'?
        comp_uninit(c->c2.comp_context);
                          ^~~~~~~~~~~~
                          mda_context
./openvpn.h:459:33: note: 'mda_context' declared here
    struct man_def_auth_context mda_context;
                                ^
init.c:2649:30: warning: implicit declaration of function 'comp_init' is invalid
      in C99 [-Wimplicit-function-declaration]
        c->c2.comp_context = comp_init(&c->options.comp);
init.c:2649:15: error: no member named 'comp_context' in 'struct context_2'; did
      you mean 'mda_context'?
        c->c2.comp_context = comp_init(&c->options.comp);
              ^~~~~~~~~~~~
              mda_context
./openvpn.h:459:33: note: 'mda_context' declared here
    struct man_def_auth_context mda_context;
                                ^
init.c:2649:28: error: assigning to 'struct man_def_auth_context' from
      incompatible type 'int'
        c->c2.comp_context = comp_init(&c->options.comp);
                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 3 errors generated.
*** Error code 1


so, NAK.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to