Hi, > Adding "!tuntap_maybe_dhcp()" here looks wrong. We must set the domain if not > set during IPv4 processing and that is indicated by did_ifconfig_setup. Just > as done in the case handled by interactive-service above.
Right, did_ifconfig_setup is not set if the IPv4 address is not pushed, in which case we don't do DHCP stuff (as seen in tuntap_post_open) and tap will be left without a DNS domain. Will remove this condition. > Once that check is removed there is no need to introduce tuntap_maybe_dhcp() > in this patch at all. Idea behind tuntap_maybe_dhcp() was to make some parts of code easier to read by hiding long "if" statements behind this function. But I agree that it would be easier to review just wmic parts and do long overdue refactoring separately. v2 is coming. -Lev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
