I have stared a bit at the code, and it all looks sane (though kp@ and
Antonio are the experts here, anyway :-) ). I have not tested things
beyond "passes client/server tests, with and without DCO" - my kernel
does not have the new code bits yet (and for a real tests, one would
have to modify it to send OVPN_NOTIF_ROTATE_KEY after like 1000 packets
or so...).
There were a few indentations that uncrustify did not like, so fixed
those one the fly (only whitespace).
Your patch has been applied to the master and release/2.6 branch
(this is somewhere between "bugfix" and "long-term compatibility",
and less of a "new feature").
commit ec71489bfc7c1d798f5f6de8e9fc187b9127072c (master)
commit c468af2cd90c9f682519eff38a21fac8a3feb148 (release/2.6)
Author: Kristof Provost
Date: Fri Apr 14 11:42:27 2023 +0200
DCO: support key rotation notifications
Signed-off-by: Kristof Provost <kprov...@netgate.com>
Acked-by: Antonio Quartulli <anto...@openvpn.net>
Message-Id: <20230414094227.9153-1-kprov...@netgate.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26590.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
