Acked-by: Gert Doering <g...@greenie.muc.de> This is all voodoo to me, but it doesn't break compilation, doesn't bring in unsafe pointer constructs, and people say "it makes their use case work", so it sounds like a good fix.
Microsoft documentation on https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessasuserw says interesting things... "The user must have full access to both the specified window station and desktop. If you want the process to be interactive, specify winsta0\default. If the lpDesktop member is NULL, the new process inherits the desktop and window station of its parent process. If this member is an empty string, "", the new process connects to a window station using the rules described in Process Connection to a Window Station." .. so we're moving from "winsta0\default" to "NULL" (startup_info is ZeroMemory'ed), which sounds like "now it will run in the desktop environment of the iservice", whatever *that* might be... but it's certainly a valid and documented choice... and since openvpn.exe "as run from iservice" doesn't want any windows etc., whatever makes it succeed sounds good to me. Your patch has been applied to the master and release/2.6 branch. (Not sure this is a "bugfix" or a "mini feature", but it certainly warrants a bit more thorough testing across Windows variants before releasing 2.6.5) commit 244d9b7942dabf0297c8f689457eeb0f9fa0aa1e (master) commit 9e112be5dde043cdc1f073f33ada0a1810b730a6 (release/2.6) Author: Selva Nair Date: Thu May 18 13:33:45 2023 -0400 Interactive service: do not force a target desktop for openvpn.exe Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20230518173345.2722530-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26705.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
