On Tue, May 09, 2023 at 05:46:58PM +0200, Gianmarco De Gregori wrote:
> This commit changes the default behavior of
> the OpenVPN configuration to enable the
> persist-key option by default.
> 
> This means that all the key file content will be kept
> in memory throughout the lifetime of the VPN connection.
> 
> Fixes: Trac #1405
> Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com>
> ---
>  doc/man-sections/generic-options.rst |  2 ++
>  src/openvpn/init.c                   | 12 ++----------
>  src/openvpn/options.c                | 23 +++++++++++------------
>  src/openvpn/options.h                |  1 -
>  4 files changed, 15 insertions(+), 23 deletions(-)
> 
> diff --git a/doc/man-sections/generic-options.rst 
> b/doc/man-sections/generic-options.rst
> index 97e1b5aa..5f74ab67 100644
> --- a/doc/man-sections/generic-options.rst
> +++ b/doc/man-sections/generic-options.rst
> @@ -303,6 +303,8 @@ which mode OpenVPN is configured as.
>    lower priority, ``n`` less than zero is higher priority).
>  
>  --persist-key
> +  DEPRECATED OPTION, corresponding behavior is now always enabled.

The usual style in the documentation seems to be "**DEPRECATED**". See
e.g. --disable-occ in the same file.

> +
>    Don't re-read key files across :code:`SIGUSR1` or ``--ping-restart``.
>  
>    This option can be combined with ``--user`` to allow restarts
[...]
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index 2680f268..9ef21bc9 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c


Please also add (DEPRECATED) marker in usage_message.

[...]

Regards,
-- 
  Frank Lichtenheld


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to