On Thu, Jul 06, 2023 at 12:04:07PM +0200, Frank Lichtenheld wrote: > We write a small .bat file wrapper and then force CMake > to use that. > > Note that we need to specify the path with / instead of \ > as path separator because otherwise run-cmake action will > mangle it. > > Change-Id: I05d3f7f3f7f7418d1977e523c6dcfb6fa5feb604 > Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> > --- > .github/workflows/build.yaml | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > This is an alternate patch to "CMake: Support doc builds on > Windows machines that do not have .py file association" since > there was some doubt on IRC whether we want to have the complexity > inside of CMake or should delegate that to the caller. > > Let me know your opinions.
Personally I prefer the original solution inside CMake. It just solves the problem in a wide range of potential setups without additional effort required by the caller. I think the slightly increased complexity can be accepted for that. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
