On Wed, Jul 12, 2023 at 01:10:53PM +0200, Frank Lichtenheld wrote:
> On Wed, Jul 12, 2023 at 11:55:29AM +0200, Arne Schwabe wrote:
> > This avoids build errors on macOS. Also the test_tls_crypt command works
> > just fine on FreeBSD with its linkers, so do not make that test Linux only.
> > 
> > Patch v2: allow running with old cmake version (cmake 3 on RHEL7 with EPEL
> >           is only 3.17)
> > Patch v3: add OPTIONAL keyword to Incldue required by some cmake versions
> 
> Yeah, I also have no idea why you didn't need that for your CMake. Anyway,
> it is correct according to the documentation. And it is definitely required
> on Ubuntu 20.04.
> 
> Tested on Ubuntu 20.04 (cmake 3.16.3), Ubuntu 22.04 (cmake 3.22.1), and
> checked build results for GHA.
> 
> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>

Note: please merge after
"Mock openvpn_exece on win32 also for test_tls_crypt" to avoid
broken MinGW builds.

Regards,
-- 
  Frank Lichtenheld


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to