flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email )
Change subject: CMake: backport CMake buildsystem from master to release/2.6 ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: Will put all the documentation/comment requests into a separate patch to make it easier to merge both in master and release/2.6 File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/315/comment/2fac3714_15b4e724 : PS1, Line 294: # TODO remove later when msvc-config.h is removed and we can always include config.h > This comment seems to be outdated, since we got rid of config-msvc. […] Acknowledged File README.cmake.md: http://gerrit.openvpn.net/c/openvpn/+/315/comment/9825cfee_238d23c0 : PS1, Line 27: can them install with a package manager of your choice (e.g. > *install them Acknowledged File contrib/cmake/git-version.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/7e42230e_d6445805 : PS1, Line 23: # > A comment what this does and why would be cool, but then maybe in master or > both here and there Acknowledged File contrib/cmake/parse-version.m4.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/abb2f492_3f01938f : PS1, Line 23: # > A comment what this does and why would be cool, but then maybe in master or > both here and there Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: d12fk <he...@openvpn.net> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Comment-Date: Tue, 19 Sep 2023 11:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk <he...@openvpn.net> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
