On Tue, Sep 19, 2023 at 05:56:35PM +0200, Frank Lichtenheld wrote: > These are based on review comments for the 2.6 backport. > But since they apply to the original master implementation > as well, I address them in this separate patch. > > - Add documentation to contrib/cmake/*.py > - Fix grammar in README.cmake.md > - Update a TODO in CMakeLists.txt to better reflect > the status quo > - Fix indentation in unit_tests' Makefile.am > > Change-Id: I4e16767ee221e1aefdd18d13b3411c27d8dd844a > Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> > Acked-by: Lev Stipakov <lstipa...@gmail.com> > --- > > This change was reviewed on Gerrit and approved by at least one > developer. I request to merge it to master. > > Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/342 > This mail reflects revision 1 of this Change. > Acked-by according to Gerrit (reflected above): > Acked-by: lstipakov <lstipa...@gmail.com> > > Manual changes: > - Fixed Lev's name in Acked-by line.
This is a test email for an idea of mine to resolve the current issues in integrating Gerrit into our workflow by extracting all the information about a reviewed change from Gerrit and submit them to the list in the traditional format so that Gert can apply the usual process for merging. Feedback welcome. I will post the script for review as well. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
