Your patch has been applied to the master branch.
I have not tested it further, given that it has plenty of ACKs (and
only affects cmake build system).
Two observations, though - the cmake changes look incomplete, there
is still many "#undef HAVE_something" left. Shouldn't they all be
completed to "#cmakedefine" for this to make sense?
Second, while not really relevant on Linux or *BSD, erroring-out
in daemon() on chdir("/") fail is not what either manpage documents -
and I do not think chdir("/") (as root) can ever fail. So changing the
code flow just to silence the compiler feels a bit meh - doing a (void)
there would have silenced it just fine. But as I said it's not
truly relevant.
What OS were you building anyway that you hit an error in compat-daemon.c
(aka "are we missing a cmake test for daemon()")?
commit 8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd (master)
Author: Lev Stipakov
Date: Wed Sep 20 14:15:19 2023 +0200
CMake: fix broken daemonization and syslog functionality
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Arne Schwabe <arne-open...@rfc2549.org>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Message-Id: <20230920121519.177949-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27045.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
