Attention is currently required from: cron2, flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork ...................................................................... Patch Set 3: (1 comment) File dev-tools/gerrit-send-mail.py: http://gerrit.openvpn.net/c/openvpn/+/361/comment/350414d1_f3f22a74 : PS3, Line 47: ack = "{} <{}>".format(reviewer.get("display_name", reviewer["name"]), reviewer.get("email", reviewer["name"])) I would be in favor of f-string everywhere, they are just so much easier to read and actually faster, not that it would matter in this case. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If4e9c2e58441efb3fd00872cd62d1cc6c607f160 Gerrit-Change-Number: 361 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-CC: d12fk <he...@openvpn.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 25 Sep 2023 21:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel