Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y ...................................................................... Patch Set 6: (3 comments) Patchset: PS6: Still some potential issues, but mostly good File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/70a97fed_b5c81c6d : PS6, Line 576: size_t key_len = mbedtls_cipher_info_get_key_bitlen(kt)/8; Hmm, you are aware that all usages in the function actually multiply the value by 8 again? File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/31a92c09_578a756e : PS6, Line 53: #include <mbedtls/net_sockets.h> Since you reverted the change that required > 2.16, you need to revert this change as well, right? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I445a93e84dc54b865b757038d22318ac427fce96 Gerrit-Change-Number: 370 Gerrit-PatchSet: 6 Gerrit-Owner: MaxF <m...@max-fillinger.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: MaxF <m...@max-fillinger.net> Gerrit-Comment-Date: Fri, 20 Oct 2023 15:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
