This is actually "V3" of the patch, but I forgot to add the -v3 when
sending from gerrit to the list.
The change is basically the same as in v1, just leaving the "real"
code alone, defusing it by setting c->c2.buf.len = 0 in the new
branch. Plus comments :-)
As in v1, this adds diagnostics to detect a non-fixable incompatibility
between 2.4.0-2.4.4 servers and DCO-enabled clients (it can only be fixed
by upgrading the server, not by a code change on the client side, or by
disabling DCO on the client - but neither can be done automatically).
Tested on the server testbed, which has DCO and no-DCO peers, V1 and V2,
which should trigger "false alarms" nicely.
Your patch has been applied to the master and release/2.6 branch (compat).
commit df7beea404df48745a608c584d863c5a377b7a1e (master)
commit e78f88d8ea113585ca16945ef0361710b838ec7d (HEAD -> release/2.6)
Author: Lev Stipakov
Date: Sun Oct 22 10:27:40 2023 +0200
dco: warn if DATA_V1 packets are sent to userspace
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg27272.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
