Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email )

Change subject: Rename state_change to continue_tls_process
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Patchset:

PS1:
Good change, but should recurse


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/452/comment/bdfcf50c_c5c3ee11 :
PS1, Line 2936:             if (!read_incoming_tls_ciphertext(&entry->buf, ks, 
&continue_tls_process))
Should rename argument of read_incoming_tls_ciphertext as well


http://gerrit.openvpn.net/c/openvpn/+/452/comment/2662067f_27eb71a1 :
PS1, Line 2947:         if (!read_incoming_tls_plaintext(ks, buf, wakeup, 
&continue_tls_process))
Should rename argument of read_incoming_tls_plaintext as well



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/452?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585
Gerrit-Change-Number: 452
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Comment-Date: Mon, 20 Nov 2023 13:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to