Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/452?usp=email )
Change subject: Rename state_change to continue_tls_process ...................................................................... Patch Set 3: (3 comments) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/452/comment/4493eb6f_5624d2ca : PS1, Line 2936: if (!read_incoming_tls_ciphertext(&entry->buf, ks, &continue_tls_process)) > Should rename argument of read_incoming_tls_ciphertext as well Done http://gerrit.openvpn.net/c/openvpn/+/452/comment/1e69d0fc_7323711d : PS1, Line 2947: if (!read_incoming_tls_plaintext(ks, buf, wakeup, &continue_tls_process)) > Should rename argument of read_incoming_tls_plaintext as well Done File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/452/comment/c4c12c6f_b4fe17bb : PS2, Line 3007: if (!write_outgoing_tls_ciphertext(session, &state_change)) > Still says state_change, breaking the build That is what you get for only testing the whole patch set and not each commit. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/452?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585 Gerrit-Change-Number: 452 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 17:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
